Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove RPCs, Request types, add mock responses until removed from dependency. #6433

Merged
merged 5 commits into from
May 30, 2024
Merged

chore: remove RPCs, Request types, add mock responses until removed from dependency. #6433

merged 5 commits into from
May 30, 2024

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented May 30, 2024 •
edited by coderabbitai bot
Loading

Description

part of #6421

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Summary by CodeRabbit

  • Deprecations

    • Removed deprecated gRPC methods DenomTraces and DenomTrace for querying denom traces.
    • Removed associated request and response types for these methods.

  • Improvements

    • Focus shifted to using the Params RPC method for querying parameters of the ibc-transfer module.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 30, 2024 •
edited
Loading

Walkthrough

Walkthrough

The recent changes involve the removal of deprecated DenomTrace and DenomTraces functions from the gRPC query services in the IBC transfer module. This cleanup also includes the elimination of related request and response message types from the query.proto file. The focus now shifts to using the Params RPC method for querying module parameters, streamlining the codebase and removing unnecessary legacy components.

Changes

File Path Change Summary
modules/apps/transfer/keeper/grpc_query.go Removed deprecated DenomTrace and DenomTraces functions related to gRPC query methods.
modules/apps/transfer/types/legacy_denomtrace.go Defined empty structs QueryDenomTracesResponse and QueryDenomTraceResponse for future removal.
proto/ibc/applications/transfer/v1/query.proto Removed deprecated DenomTraces and DenomTrace RPC methods and associated request/response message types.

Sequence Diagram(s) (Beta)

The changes do not introduce new features or modify control flow significantly, hence no sequence diagrams are necessary.

Possibly related issues

  • Remove DenomTrace and DenomTraces querier rpc's  #6421: This issue discusses the removal of DenomTrace and DenomTraces querier RPCs once dependencies are resolved. The changes in this PR directly address this objective by removing these deprecated RPC methods from the codebase.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

DimitrisJim
DimitrisJim commented May 30, 2024
View reviewed changes
modules/apps/transfer/types/legacy_denomtrace.go
@@ -0,0 +1,6 @@
package types
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't mind moving these elsewhere if people want. just chose a random file for time being.

coderabbitai[bot]
coderabbitai bot reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 80b0c9a and ed9a530.

Files ignored due to path filters (2)
  • modules/apps/transfer/types/query.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
  • modules/apps/transfer/types/query.pb.gw.go is excluded by !**/*.pb.gw.go, !**/*.pb.gw.go
Files selected for processing (3)
  • modules/apps/transfer/keeper/grpc_query.go (1 hunks)
  • modules/apps/transfer/types/legacy_denomtrace.go (1 hunks)
  • proto/ibc/applications/transfer/v1/query.proto (2 hunks)
Files skipped from review due to trivial changes (3)
  • modules/apps/transfer/keeper/grpc_query.go
  • modules/apps/transfer/types/legacy_denomtrace.go
  • proto/ibc/applications/transfer/v1/query.proto

chatton
chatton approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful diff 🪓 LGTM

coderabbitai[bot]
coderabbitai bot reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ed9a530 and 864fc8d.

Files ignored due to path filters (1)
  • modules/apps/transfer/types/query.pb.go is excluded by !**/*.pb.go, !**/*.pb.go
Files selected for processing (1)
  • proto/ibc/applications/transfer/v1/query.proto (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • proto/ibc/applications/transfer/v1/query.proto

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chatton chatton merged commit e67e30b into main May 30, 2024
74 of 76 checks passed
@chatton chatton deleted the jim/only-keep-resps branch May 30, 2024 14:20
@coderabbitai coderabbitai bot mentioned this pull request Jun 5, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

@chatton chatton chatton approved these changes

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimitrisJim @chatton @colin-axner